Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sampling API #72

Closed
reyang opened this issue May 8, 2020 · 3 comments
Closed

Add sampling API #72

reyang opened this issue May 8, 2020 · 3 comments
Milestone
Alpha v0.2

Comments

@reyang
Copy link
Member

reyang commented May 8, 2020

Add sampling API which follows https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/api-sampling.md.
@reyang reyang added this to the Alpha v0.2 milestone May 8, 2020
@reyang reyang changed the title Add Sampling API Add sampling API May 8, 2020
@pyohannes
Copy link
Contributor

Some notes:

  • This is the related spec.
  • When working on designing the interface, consider the project's ABI policy.
  • This work depends on the SpanContext, which is not available yet. Coming up with a SpanContext implementation is probably a prerequisite.
  • Ideally, first open a PR with the proposed sampler API, then work on the implementation of individual samplers once this is approved.
  • Consider implementations in other projects:

@reyang
Copy link
Member Author

reyang commented May 20, 2020 •
edited
Loading

More notes:

  • Algorithm to ensure consistent probability sampling across services - draft spec.

@reyang
Copy link
Member Author

reyang commented Aug 25, 2020

Related PRs: #118 #122 #125 #126 #128 #136 #142 #119 #136 #175 #199 #238

@reyang reyang closed this as completed Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Alpha v0.2
Development

No branches or pull requests
2 participants
@pyohannes @reyang