Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SamplingResult attributes fix #126

Merged
merged 2 commits into from
Jun 24, 2020
Merged

SamplingResult attributes fix #126

merged 2 commits into from
Jun 24, 2020

Conversation

ziqizh
Copy link
Contributor

@ziqizh ziqizh commented Jun 23, 2020

This PR fixes two mistakes in the Sampling API SamplingResult struct:

  • There is a typo making the sampler unable to compile.
  • The attribute should be a unique_ptr<const map> to be immutable, according to the spec

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files          66       66           
  Lines        1656     1656           
=======================================
  Hits         1545     1545           
  Misses        111      111

pyohannes
pyohannes approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You can take this out of draft state.

@ziqizh ziqizh marked this pull request as ready for review June 24, 2020 03:35
@ziqizh ziqizh requested a review from a team June 24, 2020 03:35
@ziqizh
Copy link
Contributor Author

ziqizh commented Jun 24, 2020

Could someone with write access merge this PR please?

@reyang reyang merged commit 6cb38fa into open-telemetry:master Jun 24, 2020
@reyang reyang mentioned this pull request Aug 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyohannes pyohannes pyohannes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ziqizh @pyohannes @reyang