Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampler Performance Testing #175

Merged
merged 15 commits into from
Jul 23, 2020

Conversation

nholbrook
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #175 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   95.69%   95.69%           
=======================================
  Files          96       96           
  Lines        2878     2878           
=======================================
  Hits         2754     2754           
  Misses        124      124           

@nholbrook nholbrook changed the title [WIP] Performance Testing Performance Testing Jul 15, 2020
@nholbrook nholbrook changed the title Performance Testing Sampler Performance Testing Jul 15, 2020
sdk/test/trace/sampler_benchmark.cc Outdated Show resolved Hide resolved
sdk/test/trace/sampler_benchmark.cc Show resolved Hide resolved
sdk/test/trace/sampler_benchmark.cc Show resolved Hide resolved
@nholbrook
Copy link
Contributor Author

Current Benchmark Results:

Benchmark Time CPU Iterations
BM_AlwaysOffSamplerConstruction 1.92 ns 1.67 ns 100000000
BM_AlwaysOnSamplerConstruction 1.89 ns 1.89 ns 74647736
BM_ParentOrElseSamplerConstruction 204 ns 203 ns 706505
BM_ProbabilitySamplerConstruction 372 ns 372 ns 387424
BM_AlwaysOffSamplerShouldSample 3.34 ns 3.34 ns 41949892
BM_AlwaysOnSamplerShouldSample 3.14 ns 3.14 ns 45300132
BM_ParentOrElseSamplerShouldSample 6.27 ns 6.27 ns 22260191
BM_ProbabilitySamplerShouldSample 5.38 ns 5.38 ns 26910475
BM_SpanCreation 657 ns 657 ns 207378
BM_NoopSpanCreation 56.1 ns 56.1 ns 2472011

sdk/test/trace/sampler_benchmark.cc Outdated Show resolved Hide resolved
sdk/test/trace/sampler_benchmark.cc Show resolved Hide resolved
sdk/test/trace/sampler_benchmark.cc Show resolved Hide resolved
sdk/test/trace/sampler_benchmark.cc Outdated Show resolved Hide resolved
sdk/test/trace/sampler_benchmark.cc Outdated Show resolved Hide resolved
sdk/test/trace/sampler_benchmark.cc Outdated Show resolved Hide resolved
@nholbrook nholbrook marked this pull request as ready for review July 20, 2020 10:55
@nholbrook nholbrook requested a review from a team July 20, 2020 10:55
Copy link
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks. Results look good, the BM_NoopSpanCreation test will for sure be useful for further optimization work.

sdk/test/trace/sampler_benchmark.cc Show resolved Hide resolved
sdk/test/trace/sampler_benchmark.cc Show resolved Hide resolved
sdk/test/trace/sampler_benchmark.cc Outdated Show resolved Hide resolved
@pyohannes pyohannes added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Jul 21, 2020
@pyohannes
Copy link
Contributor

This is ready to be merged @reyang.

@reyang
Copy link
Member

reyang commented Jul 23, 2020

Looks like there is a Bazel update again - which caused the CI to fail. Not blocking this PR merge though.

@reyang reyang merged commit 5b8cd5b into open-telemetry:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants