Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Ext folder #292

Closed

Conversation

jajanet
Copy link
Contributor

@jajanet jajanet commented Aug 22, 2020

This PR is to restructure and move all HTTP server and zPages code so that they're grouped in separate locations, meaning they can be used and included by themselves as needed. They're currently tightly coupled, so adding the HTTP server headers also includes zPages--this is not ideal. The zPages README location was also odd since there were 3 zpages folders (in include, src, and test), and now the new location (1 single zpages folder) makes more sense.

With that, this also ensures future ext additions aren't tightly coupled with the HTTP server and zPages. The number of CMake files are reduced, making future maintenance and development easier.

#288 should be merged before this.

@jajanet jajanet requested a review from a team August 22, 2020 19:22
@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #292 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #292   +/-   ##
=======================================
  Coverage   93.93%   93.93%           
=======================================
  Files         146      146           
  Lines        6564     6564           
=======================================
  Hits         6166     6166           
  Misses        398      398           
Impacted Files Coverage Δ
...lude/opentelemetry/ext/zpages/latency_boundaries.h 100.00% <ø> (ø)
...de/opentelemetry/ext/zpages/threadsafe_span_data.h 96.87% <ø> (ø)
...ges/include/opentelemetry/ext/zpages/tracez_data.h 100.00% <ø> (ø)
...nclude/opentelemetry/ext/zpages/tracez_processor.h 100.00% <ø> (ø)
ext/zpages/src/tracez_data_aggregator.cc 100.00% <ø> (ø)
ext/zpages/src/tracez_processor.cc 95.23% <ø> (ø)
ext/zpages/test/threadsafe_span_data_test.cc 100.00% <ø> (ø)
ext/zpages/test/tracez_data_aggregator_test.cc 97.34% <ø> (ø)
ext/zpages/test/tracez_processor_test.cc 98.70% <ø> (ø)

@jajanet
Copy link
Contributor Author

jajanet commented Sep 14, 2020

Likely replacing the HTTP client in the future, so restructuring changes no longer needed. See #309

@jajanet jajanet closed this Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants