-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zPages Tracez Backend Benchmarks #308
Conversation
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
=======================================
Coverage 94.59% 94.59%
=======================================
Files 146 146
Lines 6629 6629
=======================================
Hits 6271 6271
Misses 358 358
|
Triaged Dec 7 2020: Deprioritized for now. @maxgolov will take a look as time permits. This is additional functionality so not blocking. |
I'll clone the code from this PR in my branch, clean it up, and re-create since we went too far ahead with this since August 28th. |
@jajanet - that'd be awesome! Let us know if you hit any roadblocks with the new build changes. I'd be happy to help if you need any assistance with this. |
Hi all, sorry for the delay and thanks for your patience! I looked into fixing this over a weekend a few weeks ago, and ran into a separate issue with zPages that needs to be investigated before this PR can proceed. From poking around, I believe most of the zPages components work perfectly. The trouble appears to be stemming from the zPages HTTP server, as it doesn't correctly serve up data on a webpage anymore. It probably needs changes to fit the base HTTP class better. Another possible fix could be replacing this HTTP server with another one. I'll close this PR for now to help declutter the number of PRs on the repo, and hopefully can revisit this soon! |
This PR adds benchmarks for the Tracez span processor and data aggregator. These will be useful if/when deciding to change data structures or algorithms for either to measure how updates affect performance, or if completely changing the components (#184). To run these benchmarks manually, run
./ci/do_ci benchmark
. There is also the minor addition of adding the zPages OTel blog post link to the README.Note: Ext folder restructure (#292) should be merged before this. If the PR is closed instead, then I will update this PR accordingly. Main files of interest are
ext/zpages/test/tracez_processor_benchmark.cc
andext/zpages/test/tracez_data_aggregator_benchmark.cc
Benchmark results:
The arguments for the aggregator benchmarks are:
number of spans
,is_unique
, andrun_background_query