[currency] fix metrics export endpoint #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
puckpuck
changed the title
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
mviitane
approved these changes
May 25, 2023
There was a problem hiding this comment.
LGTM, runs fine. Requires a minor change to the docs:
https://opentelemetry.io/docs/demo/services/currency/
fatsheep9146
approved these changes
May 26, 2023
AlexanderWert
pushed a commit
to AlexanderWert/opentelemetry-demo
that referenced
this pull request
Jul 24, 2023
* export metrics endpoint to default config Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * export metrics endpoint to default config Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * export metrics endpoint to default config Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com>
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* export metrics endpoint to default config Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * export metrics endpoint to default config Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * export metrics endpoint to default config Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Let default metrics export (use environment variables) to control endpoint for OTLP. The
OTEL_EXPORTER_OTLP_ENDPOINTenv var is used to control all telemetry (traces and metris) export.Addresses this Helm chart issue
CHANGELOG.mdupdated to document new feature additions