Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[currency] fix metrics export endpoint #904

Merged
merged 5 commits into from
May 26, 2023
Merged

[currency] fix metrics export endpoint #904

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
573d1a2
export metrics endpoint to default config
puckpuck May 25, 2023
fd3da85
export metrics endpoint to default config
puckpuck May 25, 2023
d83c82f
export metrics endpoint to default config
puckpuck May 25, 2023
ee42a5e
Merge branch 'main' into currency.fix_metrics_export_endpoint
cartersocha May 25, 2023
c74eb60
Merge branch 'main' into currency.fix_metrics_export_endpoint
puckpuck May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ release.
([#880](https://github.com/open-telemetry/opentelemetry-demo/pull/880))
* [currencyservice] Fix OTel C++ build and update OTel version to 1.9.0
([#886](https://github.com/open-telemetry/opentelemetry-demo/pull/886))
* [currencyservice] Fix OTLP export to use default env vars
([#904](https://github.com/open-telemetry/opentelemetry-demo/pull/904))

## 1.4.0

Expand Down
1 change: 0 additions & 1 deletion src/currencyservice/src/meter_common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ namespace
otlp_exporter::OtlpGrpcMetricExporterOptions otlpOptions;

// Configuration via environment variable not supported yet
otlpOptions.endpoint = "otelcol:4317";
otlpOptions.aggregation_temporality = metric_sdk::AggregationTemporality::kDelta;
auto exporter = otlp_exporter::OtlpGrpcMetricExporterFactory::Create(otlpOptions);

Expand Down