-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASP.NET and OWIN Instrumentations - fix description for http.server.request.duration
metric
#1538
Merged
vishweshbankwar
merged 5 commits into
open-telemetry:main
from
Kielek:fix-asp.net-metrics-docs
Jan 19, 2024
Merged
ASP.NET and OWIN Instrumentations - fix description for http.server.request.duration
metric
#1538
vishweshbankwar
merged 5 commits into
open-telemetry:main
from
Kielek:fix-asp.net-metrics-docs
Jan 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lachmatt
approved these changes
Jan 18, 2024
lachmatt
reviewed
Jan 18, 2024
Kielek
added
the
comp:instrumentation.aspnet
Things related to OpenTelemetry.Instrumentation.AspNet
label
Jan 18, 2024
Kielek
changed the title
[docs] Update metric name for AspNet Instrumentation
AspNet and OWIN Instrumentations - fix description for Jan 19, 2024
http.server.request.duration
metric
Kielek
added
the
comp:instrumentation.owin
Things related to OpenTelemetry.Instrumentation.Owin
label
Jan 19, 2024
Kielek
changed the title
AspNet and OWIN Instrumentations - fix description for
ASP.NET and OWIN Instrumentations - fix description for Jan 19, 2024
http.server.request.duration
metrichttp.server.request.duration
metric
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1538 +/- ##
==========================================
+ Coverage 73.91% 78.61% +4.70%
==========================================
Files 267 24 -243
Lines 9615 477 -9138
==========================================
- Hits 7107 375 -6732
+ Misses 2508 102 -2406
Flags with carried forward coverage won't be shown. Click here to find out more. |
2 tasks
rajkumar-rangaraj
approved these changes
Jan 19, 2024
vishweshbankwar
approved these changes
Jan 19, 2024
cijothomas
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp:instrumentation.aspnet
Things related to OpenTelemetry.Instrumentation.AspNet
comp:instrumentation.owin
Things related to OpenTelemetry.Instrumentation.Owin
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #.
Changes
Update metric name for AspNet Instrumentation
For significant contributions please make sure you have completed the following items:
[ ] AppropriateCHANGELOG.md
updated for non-trivial changes[ ] Design discussion issue #[ ] Changes in public API reviewed