Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASP.NET and OWIN Instrumentations - fix description for http.server.request.duration metric #1538

Merged
merged 5 commits into from
Jan 19, 2024
Merged

ASP.NET and OWIN Instrumentations - fix description for http.server.request.duration metric #1538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
72f4137
[docs] Update metric name for AspNet Instrumentation
Kielek Jan 18, 2024
47b3d52
Fix unit
Kielek Jan 18, 2024
7d92bc9
Merge branch 'main' into fix-asp.net-metrics-docs
Kielek Jan 19, 2024
6444a08
Fix description for http.server.request.duration metrics for AspNet a…
Kielek Jan 19, 2024
9f891a0
Changelog
Kielek Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/OpenTelemetry.Instrumentation.AspNet/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

* Fix description for `http.server.request.duration` metric.
([#1538](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1538))

## 1.7.0-beta.1

Released 2023-Dec-20
Expand Down
2 changes: 1 addition & 1 deletion src/OpenTelemetry.Instrumentation.AspNet/Implementation/HttpInMetricsListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public HttpInMetricsListener(Meter meter, AspNetMetricsInstrumentationOptions op
this.httpServerDuration = meter.CreateHistogram<double>(
"http.server.request.duration",
unit: "s",
description: "Measures the duration of inbound HTTP requests.");
description: "Duration of HTTP server requests.");
TelemetryHttpModule.Options.OnRequestStoppedCallback += this.OnStopActivity;
this.options = options;
}
Expand Down
2 changes: 1 addition & 1 deletion src/OpenTelemetry.Instrumentation.AspNet/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ Currently, the instrumentation supports the following metric.

| Name | Instrument Type | Unit | Description |
|-------|-----------------|------|-------------|
| `http.server.duration` | Histogram | `ms` | Measures the duration of inbound HTTP requests. |
| `http.server.request.duration` | Histogram | `s` | Duration of HTTP server requests. |

## Advanced trace configuration

Expand Down
2 changes: 2 additions & 0 deletions src/OpenTelemetry.Instrumentation.Owin/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
([#929](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/929))
* Adds HTTP server metrics via `AddOwinInstrumentation` extension method on `MeterProviderBuilder`
([#1335](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1335))
* Fix description for `http.server.request.duration` metric.
([#1538](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1538))

## 1.0.0-rc.3

Expand Down
2 changes: 1 addition & 1 deletion src/OpenTelemetry.Instrumentation.Owin/Implementation/OwinInstrumentationMetrics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ internal static class OwinInstrumentationMetrics

public static Meter Instance => new Meter(MeterName, AssemblyName.Version.ToString());

public static Histogram<double> HttpServerDuration => Instance.CreateHistogram<double>("http.server.request.duration", "s", "Measures the duration of inbound HTTP requests.");
public static Histogram<double> HttpServerDuration => Instance.CreateHistogram<double>("http.server.request.duration", "s", "Duration of HTTP server requests.");
}
2 changes: 1 addition & 1 deletion src/OpenTelemetry.Instrumentation.Owin/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Currently, the instrumentation supports the following metric.

| Name | Instrument Type | Unit | Description |
|-------|-----------------|------|-------------|
| `http.server.request.duration` | Histogram | `s` | Measures the duration of inbound HTTP requests. |
| `http.server.request.duration` | Histogram | `s` | Duration of HTTP server requests. |

## Customize OWIN span names

Expand Down
Loading