Fix prometheus exporter to handle double values (#2317)

open-telemetry · Sep 7, 2021 · 3d5acb4 · 3d5acb4
1 parent 4ca5818
commit 3d5acb4
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 1 deletion.
diff --git a/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs b/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs
@@ -18,8 +18,8 @@
 using System.Diagnostics;
 using System.Security;
 using OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation;
-using OpenTelemetry.Trace;
 using OpenTelemetry.Metrics;
+using OpenTelemetry.Trace;
 
 namespace OpenTelemetry.Exporter
 {

diff --git a/src/OpenTelemetry.Exporter.Prometheus/PrometheusExporterExtensions.cs b/src/OpenTelemetry.Exporter.Prometheus/PrometheusExporterExtensions.cs
@@ -72,6 +72,26 @@ public static void WriteMetricsCollection(this PrometheusExporter exporter, Stre
                             break;
                         }
 
+                    case MetricType.DoubleSum:
+                        {
+                            builder = builder.WithType(PrometheusCounterType);
+                            foreach (var metricPoint in metric.GetMetricPoints())
+                            {
+                                var metricValueBuilder = builder.AddValue();
+                                metricValueBuilder = metricValueBuilder.WithValue(metricPoint.DoubleValue);
+                                if (metricPoint.Keys != null)
+                                {
+                                    for (int i = 0; i < metricPoint.Keys.Length; i++)
+                                    {
+                                        metricValueBuilder.WithLabel(metricPoint.Keys[i], metricPoint.Values[i].ToString());
+                                    }
+                                }
+                            }
+
+                            builder.Write(writer);
+                            break;
+                        }
+
                     case MetricType.LongGauge:
                         {
                             builder = builder.WithType(PrometheusGaugeType);
@@ -89,6 +109,23 @@ public static void WriteMetricsCollection(this PrometheusExporter exporter, Stre
                             break;
                         }
 
+                    case MetricType.DoubleGauge:
+                        {
+                            builder = builder.WithType(PrometheusGaugeType);
+                            foreach (var metricPoint in metric.GetMetricPoints())
+                            {
+                                var metricValueBuilder = builder.AddValue();
+                                metricValueBuilder = metricValueBuilder.WithValue(metricPoint.DoubleValue);
+                                for (int i = 0; i < metricPoint.Keys.Length; i++)
+                                {
+                                    metricValueBuilder.WithLabel(metricPoint.Keys[i], metricPoint.Values[i].ToString());
+                                }
+                            }
+
+                            builder.Write(writer);
+                            break;
+                        }
+
                     case MetricType.Histogram:
                         {
                             builder = builder.WithType(PrometheusHistogramType);