Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prometheus exporter to handle double values #2317

Merged

Conversation

cijothomas
Copy link
Member

Will do cleanups/extracting common logic to reusable functions later. This PR just addresses missing functionality.

using OpenTelemetry.Metrics;
using OpenTelemetry.Trace;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated, but required fix as metrics branch got broken with the latest main->metrics merge and conflict resolution.

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #2317 (2b5623c) into metrics (de5f0a6) will increase coverage by 0.04%.
The diff coverage is 90.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           metrics    #2317      +/-   ##
===========================================
+ Coverage    77.87%   77.91%   +0.04%     
===========================================
  Files          240      241       +1     
  Lines         7565     7617      +52     
===========================================
+ Hits          5891     5935      +44     
- Misses        1674     1682       +8     
Impacted Files Coverage Δ
src/OpenTelemetry/CompositeProcessor.cs 92.95% <ø> (ø)
...ourceInstrumentation/DiagnosticSourceSubscriber.cs 95.00% <ø> (ø)
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 70.65% <57.14%> (-1.12%) ⬇️
...metry/Trace/BatchExportActivityProcessorOptions.cs 83.33% <83.33%> (ø)
src/OpenTelemetry.Api/Baggage.cs 100.00% <100.00%> (ø)
...Telemetry.Exporter.Jaeger/JaegerExporterOptions.cs 84.21% <100.00%> (ø)
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 88.46% <100.00%> (ø)
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <100.00%> (ø)
...Telemetry.Exporter.Zipkin/ZipkinExporterOptions.cs 100.00% <100.00%> (ø)
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
... and 1 more

@cijothomas cijothomas merged commit 3d5acb4 into open-telemetry:metrics Sep 7, 2021
@cijothomas cijothomas mentioned this pull request Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants