Refactor exporter - step 8 (#1127)

* remove SimpleActivityProcessor * update changelog * remove ActivityExporter
open-telemetry · Aug 21, 2020 · 9eccaf4 · 9eccaf4
1 parent ee5b038
commit 9eccaf4
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 490 deletions.
diff --git a/src/OpenTelemetry/CHANGELOG.md b/src/OpenTelemetry/CHANGELOG.md
@@ -23,6 +23,15 @@
   [#1035](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1035))
 * Changed `AddActivitySource` to `AddSource` with params support
   ([#1036](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1036))
+* Refactored simple export and batch export APIs
+  ([#1078](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1078)
+  [#1081](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1081)
+  [#1083](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1083)
+  [#1085](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1085)
+  [#1087](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1087)
+  [#1094](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1094)
+  [#1113](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1113)
+  [#1127](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1127))
 
 ## 0.4.0-beta.2
 

diff --git a/src/OpenTelemetry/Internal/OpenTelemetrySdkEventSource.cs b/src/OpenTelemetry/Internal/OpenTelemetrySdkEventSource.cs
@@ -95,7 +95,7 @@ public void ShutdownEvent(int spansLeftUnprocessed)
         }
 
         [Event(3, Message = "Exporter returned error '{0}'.", Level = EventLevel.Warning)]
-        public void ExporterErrorResult(ExportResult exportResult)
+        public void ExporterErrorResult(ExportResultSync exportResult)
         {
             this.WriteEvent(3, exportResult.ToString());
         }

diff --git a/src/OpenTelemetry/Trace/ActivityExporter.cs b/src/OpenTelemetry/Trace/ActivityExporter.cs
diff --git a/src/OpenTelemetry/Trace/SimpleActivityProcessor.cs b/src/OpenTelemetry/Trace/SimpleActivityProcessor.cs
diff --git a/test/OpenTelemetry.Tests/Shared/TestActivityExporter.cs b/test/OpenTelemetry.Tests/Shared/TestActivityExporter.cs
diff --git a/test/OpenTelemetry.Tests/Trace/CompositeActivityProcessorTests.cs b/test/OpenTelemetry.Tests/Trace/CompositeActivityProcessorTests.cs
@@ -27,7 +27,7 @@ public class CompositeActivityProcessorTests
         public void CompositeActivityProcessor_BadArgs()
         {
             Assert.Throws<ArgumentNullException>(() => new CompositeActivityProcessor(null));
-            Assert.Throws<ArgumentException>(() => new CompositeActivityProcessor(new SimpleActivityProcessor[0]));
+            Assert.Throws<ArgumentException>(() => new CompositeActivityProcessor(new ActivityProcessor[0]));
         }
 
         [Fact]