Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor exporter - step 8 #1127

Merged
merged 3 commits into from
Aug 21, 2020
Merged

Refactor exporter - step 8 #1127

merged 3 commits into from
Aug 21, 2020

Conversation

reyang
Copy link
Member

@reyang reyang commented Aug 21, 2020

This is a follow up PR of #1078.

Changes

  • Removed SimpleActivityProcessor (which is replaced by a synchronous, zero-alloc SimpleExportActivityExporter).
  • Removed ActivityExporter (which is replaced by the ActivityExportSync class). Will send another PR to swap the class name (rename ActivityExporterSync to ActivityExporter).

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public API reviewed

@reyang reyang requested a review from a team August 21, 2020 15:40
@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #1127 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1127      +/-   ##
==========================================
+ Coverage   77.30%   77.33%   +0.02%     
==========================================
  Files         222      220       -2     
  Lines        6284     6256      -28     
==========================================
- Hits         4858     4838      -20     
+ Misses       1426     1418       -8     
Impacted Files Coverage Δ
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 80.95% <ø> (ø)
src/OpenTelemetry/Trace/ActivityProcessor.cs 57.89% <0.00%> (-5.27%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <0.00%> (+2.85%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants