Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor exporter - step 8 #1127

Merged
merged 3 commits into from
Aug 21, 2020
Merged

Refactor exporter - step 8 #1127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46276ab
remove SimpleActivityProcessor
reyang Aug 21, 2020
d2910b9
update changelog
reyang Aug 21, 2020
40a9cd5
remove ActivityExporter
reyang Aug 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/OpenTelemetry/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,15 @@
[#1035](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1035))
* Changed `AddActivitySource` to `AddSource` with params support
([#1036](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1036))
* Refactored simple export and batch export APIs
([#1078](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1078)
[#1081](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1081)
[#1083](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1083)
[#1085](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1085)
[#1087](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1087)
[#1094](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1094)
[#1113](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1113)
[#1127](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1127))

## 0.4.0-beta.2

Expand Down
2 changes: 1 addition & 1 deletion src/OpenTelemetry/Internal/OpenTelemetrySdkEventSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public void ShutdownEvent(int spansLeftUnprocessed)
}

[Event(3, Message = "Exporter returned error '{0}'.", Level = EventLevel.Warning)]
public void ExporterErrorResult(ExportResult exportResult)
public void ExporterErrorResult(ExportResultSync exportResult)
{
this.WriteEvent(3, exportResult.ToString());
}
Expand Down
80 changes: 0 additions & 80 deletions src/OpenTelemetry/Trace/ActivityExporter.cs
View file
Open in desktop

This file was deleted.

99 changes: 0 additions & 99 deletions src/OpenTelemetry/Trace/SimpleActivityProcessor.cs
View file
Open in desktop

This file was deleted.

72 changes: 0 additions & 72 deletions test/OpenTelemetry.Tests/Shared/TestActivityExporter.cs
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion test/OpenTelemetry.Tests/Trace/CompositeActivityProcessorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public class CompositeActivityProcessorTests
public void CompositeActivityProcessor_BadArgs()
{
Assert.Throws<ArgumentNullException>(() => new CompositeActivityProcessor(null));
Assert.Throws<ArgumentException>(() => new CompositeActivityProcessor(new SimpleActivityProcessor[0]));
Assert.Throws<ArgumentException>(() => new CompositeActivityProcessor(new ActivityProcessor[0]));
}

[Fact]
Expand Down
Loading