Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger Process is internal #1421

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Jaeger Process is internal #1421

merged 2 commits into from
Oct 29, 2020

Conversation

eddynaka
Copy link
Contributor

@eddynaka eddynaka commented Oct 29, 2020

Fixes #.

Changes

  • this change is moving Process from public to internal, since we don't need to expose it

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@eddynaka eddynaka requested a review from a team October 29, 2020 18:37
@eddynaka eddynaka self-assigned this Oct 29, 2020
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add changelog too, just in case...

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #1421 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1421      +/-   ##
==========================================
+ Coverage   81.22%   81.25%   +0.03%     
==========================================
  Files         227      227              
  Lines        6113     6113              
==========================================
+ Hits         4965     4967       +2     
+ Misses       1148     1146       -2     
Impacted Files Coverage Δ
...elemetry.Exporter.Jaeger/Implementation/Process.cs 81.25% <ø> (ø)
...rc/OpenTelemetry.Exporter.Jaeger/JaegerExporter.cs 84.94% <100.00%> (ø)
...us/Implementation/PrometheusExporterEventSource.cs 63.63% <0.00%> (-9.10%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 75.34% <0.00%> (+1.36%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+8.82%) ⬆️

@eddynaka
Copy link
Contributor Author

add changelog too, just in case...

done! :)

@cijothomas cijothomas merged commit a8c5797 into open-telemetry:master Oct 29, 2020
@eddynaka eddynaka deleted the feature/jaeger-process-internal branch November 3, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants