Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger Process is internal #1421

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Jaeger Process is internal #1421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
832f2db
Jaeger Process is internal
eddynaka Oct 29, 2020
7c9a9ef
updating changelog
eddynaka Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/OpenTelemetry.Exporter.Jaeger/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

* Moving Jaeger Process from public to internal.
([#1421](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1421))

## 0.7.0-beta.1

Released 2020-Oct-16
Expand Down
5 changes: 2 additions & 3 deletions src/OpenTelemetry.Exporter.Jaeger/Process.cs → ...Exporter.Jaeger/Implementation/Process.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,12 @@
using System.Collections.Generic;
using System.Linq;
using System.Text;
using OpenTelemetry.Exporter.Jaeger.Implementation;
using Thrift.Protocol;
using Thrift.Protocol.Entities;

namespace OpenTelemetry.Exporter.Jaeger
namespace OpenTelemetry.Exporter.Jaeger.Implementation
{
public class Process
internal class Process
{
public Process(string serviceName)
{
Expand Down
3 changes: 2 additions & 1 deletion src/OpenTelemetry.Exporter.Jaeger/JaegerExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
using OpenTelemetry.Trace;
using Thrift.Protocol;
using Thrift.Transport;
using Process = OpenTelemetry.Exporter.Jaeger.Implementation.Process;

namespace OpenTelemetry.Exporter.Jaeger
{
Expand Down Expand Up @@ -55,7 +56,7 @@ internal JaegerExporter(JaegerExporterOptions options, TTransport clientTranspor
this.Process = new Process(options.ServiceName, options.ProcessTags);
}

public Process Process { get; internal set; }
internal Process Process { get; set; }

internal Dictionary<string, Batch> CurrentBatches { get; } = new Dictionary<string, Batch>();

Expand Down
2 changes: 1 addition & 1 deletion test/Benchmarks/Exporter/JaegerExporterBenchmarks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public void JaegerExporter_Batching()
new JaegerExporterOptions(),
new BlackHoleTransport())
{
Process = new OpenTelemetry.Exporter.Jaeger.Process("TestService"),
Process = new OpenTelemetry.Exporter.Jaeger.Implementation.Process("TestService"),
};

for (int i = 0; i < this.NumberOfBatches; i++)
Expand Down