Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on DefaultResource's Service.Name for Exporters #1768

Merged
merged 20 commits into from
Feb 2, 2021
Merged

Rely on DefaultResource's Service.Name for Exporters #1768

merged 20 commits into from
Feb 2, 2021

Conversation

Austin-Tan
Copy link
Member

Follow up to #1744.

Changes

Previous PR #1744 changed Default Resource to comply by spec's service.name requirement. This PR will apply this to all applicable exporters.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@Austin-Tan Austin-Tan requested a review from a team February 1, 2021 22:42
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #1768 (88846d0) into main (7d8c403) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1768      +/-   ##
==========================================
+ Coverage   84.16%   84.19%   +0.02%     
==========================================
  Files         187      187              
  Lines        5931     5934       +3     
==========================================
+ Hits         4992     4996       +4     
+ Misses        939      938       -1     
Impacted Files Coverage Δ
...Telemetry.Exporter.Zipkin/ZipkinExporterOptions.cs 100.00% <ø> (ø)
...rc/OpenTelemetry.Exporter.Jaeger/JaegerExporter.cs 85.00% <100.00%> (+1.66%) ⬆️
...rc/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs 87.64% <100.00%> (+0.14%) ⬆️
src/OpenTelemetry/ProviderExtensions.cs 75.00% <100.00%> (+8.33%) ⬆️

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit c141779 into open-telemetry:main Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants