-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public setter for MetricReaderOptions.PeriodicExportingMetricReaderOptions #3184
Public setter for MetricReaderOptions.PeriodicExportingMetricReaderOptions #3184
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3184 +/- ##
==========================================
+ Coverage 84.87% 85.16% +0.28%
==========================================
Files 259 259
Lines 9330 9330
==========================================
+ Hits 7919 7946 +27
+ Misses 1411 1384 -27
|
Might have a flakey Prometheus test From this run:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a changelog is important as this is going to be stable release in a day!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#2620 (comment)