Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SqlClient] Clarify behavior when using System.Data.SqlClient with .NET Framework #3937

Merged
merged 9 commits into from
Nov 29, 2022
Merged

[SqlClient] Clarify behavior when using System.Data.SqlClient with .NET Framework #3937

merged 9 commits into from
Nov 29, 2022

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Nov 23, 2022 •
edited
Loading

Fixes #.
#3900 (comment)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@vishweshbankwar vishweshbankwar marked this pull request as ready for review November 23, 2022 21:50
@vishweshbankwar vishweshbankwar requested a review from a team November 23, 2022 21:50
@codecov
Copy link

codecov bot commented Nov 23, 2022 •
edited
Loading

Codecov Report

Merging #3937 (9266491) into main (39283c7) will increase coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3937      +/-   ##
==========================================
+ Coverage   85.18%   85.25%   +0.06%     
==========================================
  Files         287      287              
  Lines       11026    11026              
==========================================
+ Hits         9393     9400       +7     
+ Misses       1633     1626       -7
Impacted Files Coverage Δ
...ation.SqlClient/SqlClientInstrumentationOptions.cs 98.66% <ø> (ø)
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <0.00%> (+2.85%) ⬆️
...lementation/SqlClientInstrumentationEventSource.cs 75.00% <0.00%> (+4.16%) ⬆️
...porter.OpenTelemetryProtocol/OtlpMetricExporter.cs 86.36% <0.00%> (+13.63%) ⬆️
...tation/OpenTelemetryProtocolExporterEventSource.cs 100.00% <0.00%> (+15.00%) ⬆️

@TimothyMothra TimothyMothra mentioned this pull request Nov 23, 2022
Merged
3 tasks
Vishwesh Bankwar added 2 commits November 23, 2022 14:21
@vishweshbankwar @TimothyMothra
Update src/OpenTelemetry.Instrumentation.SqlClient/README.md
093304b 
Co-authored-by: Timothy Mothra <tilee@microsoft.com>
CodeBlanch
CodeBlanch approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit e376aef into open-telemetry:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyMothra TimothyMothra TimothyMothra approved these changes

@CodeBlanch CodeBlanch CodeBlanch approved these changes

@reyang reyang reyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vishweshbankwar @reyang @CodeBlanch @TimothyMothra