Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SqlClient] Clarify behavior when using System.Data.SqlClient with .NET Framework #3937

Merged
merged 9 commits into from
Nov 29, 2022
Merged

[SqlClient] Clarify behavior when using System.Data.SqlClient with .NET Framework #3937

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2634770
Add System.Data.SqlClient clarification for netfmk
Nov 23, 2022
11ec7f9
wrap comment
Nov 23, 2022
5f7643d
readme update
Nov 23, 2022
441f38d
readme
Nov 23, 2022
093304b
Update src/OpenTelemetry.Instrumentation.SqlClient/README.md
vishweshbankwar Nov 23, 2022
72ddca4
Merge branch 'main' into vibankwa/clarify-system-microsoft-behavior-f…
vishweshbankwar Nov 24, 2022
3593c8a
resolve PR comments
Nov 29, 2022
432bc0f
Merge branch 'vibankwa/clarify-system-microsoft-behavior-for-netfmk' …
Nov 29, 2022
9266491
Merge branch 'main' into vibankwa/clarify-system-microsoft-behavior-f…
CodeBlanch Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/OpenTelemetry.Instrumentation.SqlClient/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@ using var tracerProvider = Sdk.CreateTracerProviderBuilder()
.Build();
```

On .NET Framework, `System.Data.SqlClient` only exposes stored procedure names and
not the full query text. On `Microsoft.Data.SqlClient`, stored procedure command
or full query text will be collected based on `SqlCommand.CommandType`.
vishweshbankwar marked this conversation as resolved.
Show resolved Hide resolved

### EnableConnectionLevelAttributes

**Note:** EnableConnectionLevelAttributes is supported on all runtimes.
Expand Down
3 changes: 3 additions & 0 deletions src/OpenTelemetry.Instrumentation.SqlClient/SqlClientInstrumentationOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ public class SqlClientInstrumentationOptions
/// <c>SqlCommand</c>s regardless of <see cref="CommandType"/>. Use
/// SetDbStatementForText to capture Text, StoredProcedure, and all
/// other command text.</item>
/// <item>When using <c>System.Data.SqlClient</c> on .NET Framework, the
/// instrumentation will only capture <c>sqlCommand.CommandText</c> for
/// <see cref="CommandType.StoredProcedure"/> commands.</item>
vishweshbankwar marked this conversation as resolved.
Show resolved Hide resolved
/// </list>
/// </para>
/// </remarks>
Expand Down