[SDK] Remove the dependency on M.E.C.EnvironmentVariables #4092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntVariables from SDK.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4092 +/- ##
==========================================
- Coverage 85.59% 85.49% -0.11%
==========================================
Files 289 292 +3
Lines 11261 11306 +45
==========================================
+ Hits 9639 9666 +27
- Misses 1622 1640 +18
|
reyang
approved these changes
Jan 23, 2023
CodeBlanch
commented
Jan 23, 2023
Comment on lines
+18
to
+21
| private const string MySqlServerPrefix = "MYSQLCONNSTR_"; | ||
| private const string SqlAzureServerPrefix = "SQLAZURECONNSTR_"; | ||
| private const string SqlServerPrefix = "SQLCONNSTR_"; | ||
| private const string CustomConnectionStringPrefix = "CUSTOMCONNSTR_"; |
There was a problem hiding this comment.
@alanwest @cijothomas I was just chatting with @reyang about this. So the new feature we are supporting in 1.4.0 is we will look for environment variables using IConfiguration. This code is only ever used for Sdk.Create* style to build IConfiguration from environment variables as backwards compatibility for users without hosting. So strictly speaking, we do not need this connection string logic. We don't support it in 1.3.0 and we don't need to in 1.4.0. Thinking we should remove this and slim it down as a follow-up.
alanwest
approved these changes
Jan 24, 2023
xiang17
added a commit
to xiang17/opentelemetry-dotnet-instrumentation
that referenced
this pull request
Feb 2, 2023
2 tasks
aunikitin
pushed a commit
to aunikitin/opentelemetry-dotnet
that referenced
this pull request
Feb 4, 2023
…etry#4092) * Remove the dependency on Microsoft.Extensions.Configuration.EnvironmentVariables from SDK. * Added notes. * CHANGELOG patch.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4084
Changes
Consumes the bits from Microsoft.Extensions.Configuration.EnvironmentVariables so the SDK doesn't need a dependency.
TODOs
CHANGELOG.mdupdated for non-trivial changes