Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed match connectionString prefix support from EnvironmentVariablesConfigurationProvider. #4106

Merged

Conversation

Yun-Ting
Copy link
Contributor

@Yun-Ting Yun-Ting marked this pull request as ready for review January 26, 2023 19:03
@Yun-Ting Yun-Ting requested a review from a team January 26, 2023 19:03
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #4106 (70dcc08) into main (03af717) will increase coverage by 0.08%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4106      +/-   ##
==========================================
+ Coverage   85.46%   85.55%   +0.08%     
==========================================
  Files         292      293       +1     
  Lines       11306    11317      +11     
==========================================
+ Hits         9663     9682      +19     
+ Misses       1643     1635       -8     
Impacted Files Coverage Δ
...Telemetry.Exporter.Jaeger/JaegerExporterOptions.cs 100.00% <ø> (ø)
...elemetryProtocol/Implementation/SdkLimitOptions.cs 100.00% <ø> (ø)
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 100.00% <ø> (ø)
...Telemetry.Exporter.Zipkin/ZipkinExporterOptions.cs 100.00% <ø> (ø)
...emetry/Internal/Options/ConfigurationExtensions.cs 100.00% <ø> (ø)
...metry/Trace/BatchExportActivityProcessorOptions.cs 100.00% <ø> (ø)
...metry/Internal/Options/DelegatingOptionsFactory.cs 65.51% <65.51%> (ø)
...ables/EnvironmentVariablesConfigurationProvider.cs 80.00% <100.00%> (+16.84%) ⬆️
...p/Implementation/HttpInstrumentationEventSource.cs 72.00% <0.00%> (-4.00%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <0.00%> (+2.85%) ⬆️
... and 3 more

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit fd6fb90 into open-telemetry:main Jan 26, 2023
@Yun-Ting Yun-Ting deleted the yunl/removeConnectionString branch January 26, 2023 19:35
aunikitin pushed a commit to aunikitin/opentelemetry-dotnet that referenced this pull request Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants