-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[http] Avoid boxing of status code tags #4361
Merged
CodeBlanch
merged 4 commits into
open-telemetry:main
from
CodeBlanch:http-statuscode-boxing
Apr 4, 2023
Merged
[http] Avoid boxing of status code tags #4361
CodeBlanch
merged 4 commits into
open-telemetry:main
from
CodeBlanch:http-statuscode-boxing
Apr 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishweshbankwar
approved these changes
Apr 4, 2023
reyang
reviewed
Apr 4, 2023
src/OpenTelemetry.Instrumentation.Http/Implementation/TelemetryHelper.cs
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4361 +/- ##
==========================================
+ Coverage 84.79% 84.82% +0.02%
==========================================
Files 299 300 +1
Lines 12057 12065 +8
==========================================
+ Hits 10224 10234 +10
+ Misses 1833 1831 -2
|
reyang
reviewed
Apr 4, 2023
#pragma warning restore SA1509 // Opening braces should not be preceded by blank line | ||
static TelemetryHelper() | ||
{ | ||
BoxedStatusCodes = new object[500]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JamesNK FYI.
reyang
approved these changes
Apr 4, 2023
utpilla
reviewed
Apr 4, 2023
src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerDiagnosticListener.cs
Show resolved
Hide resolved
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
a dictionaryan array of pre-boxed status code values to avoid boxing perf hit on every request. Borrowed from AspNetCore's upcoming metric support.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes