Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AspNetCore+Http] StatusCode boxing logic improvements #4363

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Apr 4, 2023

Changes

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Appropriate CHANGELOG.md files updated for non-trivial changes

@CodeBlanch CodeBlanch requested a review from a team April 4, 2023 23:27
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #4363 (d5aba59) into main (6c06bcc) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4363      +/-   ##
==========================================
- Coverage   84.81%   84.74%   -0.08%     
==========================================
  Files         300      300              
  Lines       12065    12003      -62     
==========================================
- Hits        10233    10172      -61     
+ Misses       1832     1831       -1     
Impacted Files Coverage Δ
...rumentation.Http/Implementation/TelemetryHelper.cs 100.00% <ø> (ø)
...ation.AspNetCore/Implementation/TelemetryHelper.cs 85.71% <100.00%> (-12.92%) ⬇️
...ation.AspNetCore/MeterProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...tion.AspNetCore/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...rumentation.Http/MeterProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...umentation.Http/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@utpilla utpilla merged commit a61711d into open-telemetry:main Apr 4, 2023
@CodeBlanch CodeBlanch deleted the statuscode-boxing-updates branch April 5, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants