[sdk-logs] Add BatchExportLogRecordProcessorOptions to SDK #4446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 tasks
utpilla
reviewed
Apr 26, 2023
utpilla
approved these changes
Apr 26, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4446 +/- ##
==========================================
- Coverage 84.66% 84.61% -0.05%
==========================================
Files 308 309 +1
Lines 12235 12248 +13
==========================================
+ Hits 10359 10364 +5
- Misses 1876 1884 +8
|
vishweshbankwar
approved these changes
Apr 26, 2023
CodeBlanch
commented
Apr 26, 2023
Comment on lines
+35
to
+39
| /// <item>The environment variable keys are currently experimental and subject | ||
| /// to change. See: <see | ||
| /// href="https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/sdk-environment-variables.md#batch-logrecord-processor">OpenTelemetry | ||
| /// Environment Variable Specification - Batch LogRecord Processor</see>. | ||
| /// </item> |
There was a problem hiding this comment.
Hoping to get these marked as stable: open-telemetry/opentelemetry-specification#3449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #4433
Changes
BatchExportLogRecordProcessorOptionsto SDK. This class will be used by log exporters (ex: https://github.com/open-telemetry/opentelemetry-dotnet/pull/4416/files#diff-7a71b7f380cd5f1d4c9d5e4062ac3ea6d3491adc011052b42dec566de7fa8d24R29)Merge requirement checklist