-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark LogRecord EnvVars stable #3449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a changelog entry.
Hmm, this was an oversight too: https://github.com/open-telemetry/opentelemetry-specification/pull/3449/files#diff-b31589a66a50cd233a213894f3b191e3f42892c34a0ba72d28dc1e0749f43046R128 We'd settled on 1000ms default for exportTimeoutMillis in #3002. |
Updated...
|
Relates to #3376
Changes
Details
#3376 marked most of the logs spec stable but we noticed implementing things in .NET that the EnvVars were still experimental. This felt like an oversight so here's a PR to fix things up.
/cc @alanwest @utpilla @jack-berg @tigrannajaryan