Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark LogRecord EnvVars stable #3449

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Conversation

CodeBlanch
Copy link
Member

Relates to #3376

Changes

  • Mark LogRecord Environment Variable spec regions as stable

Details

#3376 marked most of the logs spec stable but we noticed implementing things in .NET that the EnvVars were still experimental. This felt like an oversight so here's a PR to fix things up.

/cc @alanwest @utpilla @jack-berg @tigrannajaryan

@CodeBlanch CodeBlanch requested review from a team April 26, 2023 22:40
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a changelog entry.

@alanwest
Copy link
Member

Hmm, this was an oversight too: https://github.com/open-telemetry/opentelemetry-specification/pull/3449/files#diff-b31589a66a50cd233a213894f3b191e3f42892c34a0ba72d28dc1e0749f43046R128

We'd settled on 1000ms default for exportTimeoutMillis in #3002. OTEL_BLRP_SCHEDULE_DELAY should be changed to match before we mark stable.

@arminru arminru added spec:logs Related to the specification/logs directory area:sdk Related to the SDK area:configuration Related to configuring the SDK labels Apr 27, 2023
@CodeBlanch
Copy link
Member Author

Updated...

  • Set OTEL_BLRP_SCHEDULE_DELAY to 1000
  • Added CHANGELOG entry

@reyang reyang merged commit f9c26af into open-telemetry:main Apr 28, 2023
@CodeBlanch CodeBlanch deleted the log-envvar-stable branch May 4, 2023 21:57
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:configuration Related to configuring the SDK area:sdk Related to the SDK spec:logs Related to the specification/logs directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants