Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdk-logs] Update the XML comments on BatchExportLogRecordProcessorOptions #4463

Merged
merged 1 commit into from
May 4, 2023
Merged

[sdk-logs] Update the XML comments on BatchExportLogRecordProcessorOptions #4463

merged 1 commit into from
May 4, 2023

Conversation

CodeBlanch
Copy link
Member

Relates to #4433

Changes

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch requested a review from a team May 4, 2023 21:57
@CodeBlanch CodeBlanch mentioned this pull request May 4, 2023
Open
53 tasks
@CodeBlanch CodeBlanch merged commit 7e784e8 into open-telemetry:main May 4, 2023
@CodeBlanch CodeBlanch deleted the sdk-logs-specupdates branch May 4, 2023 22:17
CodeBlanch
CodeBlanch commented May 4, 2023
View reviewed changes
src/OpenTelemetry/Logs/BatchExportLogRecordProcessorOptions.cs
/// <remarks>
/// Notes:
/// <list type="bullet">
/// <item>The constructor throws <see cref="FormatException"/> if it fails to
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anyone curious the FormatException logic was changed a while back so this comment was lying: #4095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanwest alanwest alanwest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodeBlanch @alanwest