Mark logs bridge API / SDK as stable #3376
Conversation
|
OMFG 😍 !!! |
There was a problem hiding this comment.
LGTM with a non-blocking comment https://github.com/open-telemetry/opentelemetry-specification/pull/3376/files#r1163017575.
|
Must also resolve #3397 before merging. Because of multiple last minutes changes we will have to extend the cooldown period on this PR. Let's not rush. |
|
This should be unblocked now. Agree with having a cooldown period given the recent changes. |
|
@jack-berg I suggest we ask all prototype implementations to review the recent changes and confirm that they are implementable before we merge this. |
|
@tigrannajaryan good idea. Tracking feedback from maintainers in this comment. |
|
We have confirmation from all prototypes: #2911 (comment) Let's keep this open for another couple days and then merge. @open-telemetry/specs-approvers and @open-telemetry/specs-logs-approvers we want to see a lot more approvals on this. |
|
We have enough approvals. We will merge this tomorrow, one week after the last changes to logs spec. |
|
Congrats everyone and thank you for proposing, reviewing, debating, arguing and contributing in some other way! |
|
@jack-berg @tigrannajaryan Shouldn't there be a changelog line for this? 😉 |
|
Oops thanks. See #3446. |
All items in #2911 have been completed and I believe logs can now be marked stable.