Added setOpenTelemetry method to appender

[rupinder10]

Added setOpenTelemetry method to appender to allow for SDK based implementations to use it (#8222). Added new test cases too.

[linux-foundation-easycla]

• ✅ login: rupinder10 / name: Rupinder Singh (54e4183, d6f1e82)
• ❌ The email address for the commit (9cb7c2c, 96f1aa3, ca0affa, acf429c) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

[trask]

thanks @rupinder10!

we discussed this briefly in the Java SIG meeting today, and wondering if it would work to pass in OpenTelemetry instance instead of LoggerProvider?

this would match other library instrumentations which accept OpenTelemetry (e.g. instead of TraceProvider and MeterProvider)

and also would help hide LoggerProvider a bit more, which we don't really want people to use directly given that it could confuse them into thinking it's a more general logging library (instead of a log bridge)

[rupinder10]

thanks @rupinder10!

we discussed this briefly in the Java SIG meeting today, and wondering if it would work to pass in OpenTelemetry instance instead of LoggerProvider?

this would match other library instrumentations which accept OpenTelemetry (e.g. instead of TraceProvider and MeterProvider)

and also would help hide LoggerProvider a bit more, which we don't really want people to use directly given that it could confuse them into thinking it's a more general logging library (instead of a log bridge)

That is also a possibility. And you arguments for that make sense. I had a Pull Request created with those changes for the LoggerProvider . I will cancel that and explore the OpenTelemetry instance as a field

[rupinder10]

@trask on second thought, I noticed that OpenTelemetry doesn't have a getLoggerProvider() method although the OpenTelemetrySdkBuilder does have a setLoggerBuilder() method.

So if we go with that approach, we would also need to add a getter in OpenTelemetry in the API too.

[trask]

oh, right, that getter is being added in open-telemetry/opentelemetry-java#5341

can this PR wait for that?

[rupinder10]

oh, right, that getter is being added in open-telemetry/opentelemetry-java#5341

can this PR wait for that?

Depends upon when does that get done. Is there some rough estimate on that ?

[trask]

oh, right, that getter is being added in open-telemetry/opentelemetry-java#5341
can this PR wait for that?

Depends upon when does that get done. Is there some rough estimate on that ?

it seems likely that it will make it into the next release, but it is pending open-telemetry/opentelemetry-specification#3376 so it's not certain

[rupinder10]

open-telemetry/opentelemetry-java#5341
can this PR wait for that?

@trask I noticed that open-telemetry/opentelemetry-java#5341 is now ready to merge. Is there a timeline to get this done so that I can restart my work ?

[trask]

I think the plan is to merge that into 1.27.0, which is targeted for June 9

[rupinder10]

I think the plan is to merge that into 1.27.0, which is targeted for June 9

So what should the process be for me to be able to make the corresponging changes to the otel log4j appender in opentelemetry-java-instrumentation without having to wait for June 6th ? It would be awesome if I can get a pull request ready about the same time that 1.27.0 is released.

[trask]

hey @rupinder10, target release for opentelemetry-java repository 1.27.0 is this Friday. Within a couple of hours after that release, an automated PR will be generated against this repository that updates this repo to OTel Java SDK 1.27.0.

if you keep your eye out for that PR, you can rebase your PR against that PR.

the target release for this repository 1.27.0 is the following Wednesday

[rupinder10]

Is there a time I should I look for ? From: Trask Stalnaker ***@***.***> Sent: Monday, June 5, 2023 6:34 PM To: open-telemetry/opentelemetry-java-instrumentation ***@***.***> Cc: Rupinder Singh ***@***.***>; Mention ***@***.***> Subject: Re: [open-telemetry/opentelemetry-java-instrumentation] Added setLoggerProvider method to appender (PR #8231) hey @rupinder10 <https://github.com/rupinder10> , target release for opentelemetry-java repository 1.27.0 is this Friday. Within a couple of hours after that release, an automated PR will be generated against this repository that updates this repo to OTel Java SDK 1.27.0. if you keep your eye out for that PR, you can rebase your PR against that PR. the target release for this repository 1.27.0 is the following Wednesday — Reply to this email directly, view it on GitHub <#8231 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB56UZ3E2QI7GFCCYD2ZLRLXJZNHLANCNFSM6AAAAAAWVWGEWA> . You are receiving this because you were mentioned. <https://github.com/notifications/beacon/AB56UZ4KI3FFAPHJW62BYA3XJZNHLA5CNFSM6AAAAAAWVWGEWCWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS6A7LOG.gif> Message ID: ***@***.*** ***@***.***> >

[linux-foundation-easycla]

• ✅ login: rupinder10 / name: Rupinder Singh (54e4183, d6f1e82, 76bf73f)
• ❌ The email address for the commit (9cb7c2c, 96f1aa3, ca0affa, acf429c) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

[linux-foundation-easycla]

• ✅ login: rupinder10 / name: Rupinder Singh (54e4183, d6f1e82, 76bf73f)
• ❌ The email address for the commit (9cb7c2c, 96f1aa3, ca0affa, acf429c) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

[trask]

Is there a time I should I look for?

you could watch releases for https://github.com/open-telemetry/opentelemetry-java

[trask]

@rupinder10 heads up it looks like there's an EasyCLA issue (see above #8231 (comment)), you may want to try squashing and force pushing to resolve

[rupinder10]

I had removed the commits that had the EasyCLA issue. Hopefully it will not be a problem

[trask]

I had removed the commits that had the EasyCLA issue. Hopefully it will not be a problem

oh, my bad, it looks like EasyCLA is passing (looking at the checks), I was confused by the EasyCLA comments above which were still red (I thought it would update those, but guess not)

[linux-foundation-easycla]

• ❌ The email address for the commit (a749938) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

[linux-foundation-easycla]

• ❌ The email address for the commit (a749938) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

[trask]

@rupinder10 can you try squash to resolve EasyCLA failure? thx

[linux-foundation-easycla]

• ❌ The email address for the commit (36ecbf0) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

[rupinder10]

@rupinder10 can you try squash to resolve EasyCLA failure? thx

All done. checks passing

[mateuszrzeszutek]

Thanks @rupinder10 , this is great! 🚀