Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Fix more ordering issues with ExposeExperimentalFeatures compiler switch #4832

Merged

Conversation

CodeBlanch
Copy link
Member

Changes

  • Fixes more ordering issues around the EXPOSE_EXPERIMENTAL_FEATURES MSBuild resolution logic

@CodeBlanch CodeBlanch requested a review from a team September 6, 2023 18:29
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #4832 (9fd2566) into main (268d29a) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4832      +/-   ##
==========================================
- Coverage   83.92%   83.89%   -0.03%     
==========================================
  Files         293      293              
  Lines       11998    11998              
==========================================
- Hits        10069    10066       -3     
- Misses       1929     1932       +3     

@utpilla utpilla merged commit 5cc1f39 into open-telemetry:main Sep 6, 2023
26 checks passed
@CodeBlanch CodeBlanch deleted the experimental-features-build-fix-2 branch September 6, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants