[repo] Common.prod.props & csproj cleanup #4835
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Common.prod.props
:GenerateDocumentationFile
(it is already part ofCommon.props
)PropertyGroup
s andItemGroup
s and reorganized them at the top of the file<NoWarn>$(NoWarn),1573,1712</NoWarn>
and fixed the one warning that manifested as a result (missing XML docs for a couple parameters inDelegatingOptionsFactory.cs
)csproj
files:Includes\
path$(ExposeExperimentalFeatures)
:PostResolveExposeExperimentalFeatures
). This worked fine more or less but the files were no longer showing in Visual Studio which could cause some confusion. The new version let's the project files add what they want and then the target doing resolution (ResolveExposeExperimentalFeatures
) REMOVES them based on the final resolved$(ExposeExperimentalFeatures)
. This makes thecsproj
files more readable (debatable) but more importantly restores the files in Visual Studio. This also clears a warning that was showing up about duplicate files being added in OTLP project but I could have fixed it using the old way too.