Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve console logging example by explaining more about Dispose #4869

Merged

Conversation

reyang
Copy link
Member

@reyang reyang commented Sep 19, 2023

Follow up #4855 (comment)

@reyang reyang requested a review from a team September 19, 2023 23:55
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #4869 (a808ef4) into main (15a54bb) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4869      +/-   ##
==========================================
+ Coverage   83.12%   83.15%   +0.02%     
==========================================
  Files         293      293              
  Lines       11984    11984              
==========================================
+ Hits         9962     9965       +3     
+ Misses       2022     2019       -3     
Flag Coverage Δ
unittests 83.15% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@CodeBlanch CodeBlanch merged commit 535c819 into open-telemetry:main Sep 21, 2023
26 checks passed
@reyang reyang deleted the reyang/console-logging-example-dispose branch March 2, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants