Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update more examples to align with the recommended path #4886

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

reyang
Copy link
Member

@reyang reyang commented Sep 26, 2023

Update few more test cases to align with #4878 and #4869.

@reyang reyang requested a review from a team September 26, 2023 02:40
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #4886 (307d1cf) into main (a80d7ce) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4886      +/-   ##
==========================================
- Coverage   82.92%   82.88%   -0.05%     
==========================================
  Files         294      294              
  Lines       12188    12188              
==========================================
- Hits        10107    10102       -5     
- Misses       2081     2086       +5     
Flag Coverage Δ
unittests 82.88% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@reyang reyang closed this Sep 27, 2023
@reyang reyang reopened this Sep 27, 2023
@CodeBlanch CodeBlanch merged commit bc1badf into open-telemetry:main Sep 27, 2023
51 of 52 checks passed
@reyang reyang deleted the reyang/align-examples branch March 2, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants