Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-metrics] Customer ExemplarReservoir and View API configuration #5624

Merged

Conversation

CodeBlanch
Copy link
Member

Relates to #2527

Changes

  • Adds documentation which shows how to implement custom ExemplarReservoirs and use the View API to configure them for a metric

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch added documentation Documentation related metrics Metrics signal related labels May 16, 2024
@CodeBlanch CodeBlanch requested a review from a team May 16, 2024 21:58
@CodeBlanch CodeBlanch mentioned this pull request May 16, 2024
6 tasks
@@ -331,6 +331,28 @@ var meterProvider = Sdk.CreateMeterProviderBuilder()
.Build();
```

### Changing the ExemplarReservoir for a Metric

To set the [ExemplarReservoir](#exemplarreservoir) for an individual metric, use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start with saying "The default Reservoir is xyz. There is no ability to change default Reservoir. However, an experimental API is available to change the Reservoir using the View API"...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel this is really necessary. The ExemplarReservoir link/anchor there jumps down to the section with all that detail.

I did add this though: 9dcb5be

@CodeBlanch CodeBlanch merged commit 2abf2a9 into open-telemetry:main May 20, 2024
16 checks passed
@CodeBlanch CodeBlanch deleted the docs-metrics-exemplarreservoir branch May 20, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related metrics Metrics signal related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants