-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-metrics] Customer ExemplarReservoir and View API configuration #5624
Merged
CodeBlanch
merged 11 commits into
open-telemetry:main
from
CodeBlanch:docs-metrics-exemplarreservoir
May 20, 2024
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
574887f
Add exemplar reservoir docs.
CodeBlanch f60e07b
Add feedback link.
CodeBlanch 572906a
Code review.
CodeBlanch f8ed6d3
Code review.
CodeBlanch 9dcb5be
Tweak.
CodeBlanch c1017d5
Lint.
CodeBlanch 15e16ab
Link fix.
CodeBlanch 02ce7f0
Merge branch 'main' into docs-metrics-exemplarreservoir
CodeBlanch 5431913
Code review.
CodeBlanch fcf3da6
Merge branch 'docs-metrics-exemplarreservoir' of https://github.com/C…
CodeBlanch 61eb277
Merge branch 'main' into docs-metrics-exemplarreservoir
CodeBlanch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start with saying "The default Reservoir is xyz. There is no ability to change default Reservoir. However, an experimental API is available to change the Reservoir using the View API"...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel this is really necessary. The
ExemplarReservoir
link/anchor there jumps down to the section with all that detail.I did add this though: 9dcb5be