OTEL_RESOURCE_(LABELS -> ATTRIBUTES) #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran into an issue getting Lightstep running locally, and realized it was due to a name change on the `OTEL_RESOURCE_LABELS` env variable. It recently changed in the spec. open-telemetry/opentelemetry-specification#758 https://github.com/open-telemetry/opentelemetry-specification/blob/c9eeaaec21a3afa421546dd9c92221ba537dde82/specification/sdk-environment-variables.md
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
==========================================
- Coverage 32.13% 32.10% -0.04%
==========================================
Files 63 63
Lines 2981 2981
==========================================
- Hits 958 957 -1
- Misses 2023 2024 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tsloughter
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into an issue getting Lightstep running locally, and realized it was
due to a name change on the
OTEL_RESOURCE_LABELSenv variable. Itrecently changed in the spec.
open-telemetry/opentelemetry-specification#758
https://github.com/open-telemetry/opentelemetry-specification/blob/c9eeaaec21a3afa421546dd9c92221ba537dde82/specification/sdk-environment-variables.md