-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OTEL_RESOURCE_ATTRIBUTES instead of OTEL_RESOURCE_LABELS. #758
Merged
carlosalberto
merged 1 commit into
open-telemetry:master
from
carlosalberto:update_to_resource_attributes
Aug 6, 2020
Merged
Use OTEL_RESOURCE_ATTRIBUTES instead of OTEL_RESOURCE_LABELS. #758
carlosalberto
merged 1 commit into
open-telemetry:master
from
carlosalberto:update_to_resource_attributes
Aug 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosalberto
added
spec:resource
Related to the specification/resource directory
area:sdk
Related to the SDK
labels
Aug 5, 2020
arminru
approved these changes
Aug 6, 2020
@open-telemetry/specs-approvers please review this one - it's (I think) a straightforward item. |
codeboten
approved these changes
Aug 6, 2020
bogdandrutu
approved these changes
Aug 6, 2020
codeboten
pushed a commit
to codeboten/opentelemetry-go
that referenced
this pull request
Aug 6, 2020
As per the specification here open-telemetry/opentelemetry-specification#758
codeboten
pushed a commit
to codeboten/opentelemetry-python
that referenced
this pull request
Aug 6, 2020
The environment variable OTEL_RESOURCE has been renamed to OTEL_RESOURCE_ATTRIBUTES as per the specification open-telemetry/opentelemetry-specification#758
5 tasks
MrAlias
pushed a commit
to open-telemetry/opentelemetry-go
that referenced
this pull request
Aug 7, 2020
* Renaming OTEL_RESOURCE_LABELS env var As per the specification here open-telemetry/opentelemetry-specification#758 * update changelog
davydog187
added a commit
to davydog187/opentelemetry-erlang
that referenced
this pull request
Oct 30, 2020
Ran into an issue getting Lightstep running locally, and realized it was due to a name change on the `OTEL_RESOURCE_LABELS` env variable. It recently changed in the spec. open-telemetry/opentelemetry-specification#758 https://github.com/open-telemetry/opentelemetry-specification/blob/c9eeaaec21a3afa421546dd9c92221ba537dde82/specification/sdk-environment-variables.md
shbieng
added a commit
to shbieng/opentelemetry-go
that referenced
this pull request
Aug 26, 2022
* Renaming OTEL_RESOURCE_LABELS env var As per the specification here open-telemetry/opentelemetry-specification#758 * update changelog
carlosalberto
added a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #666
The reason being that Resource Labels were (relatively recently) renamed to Resource Attributes.