Ensure all XRay Sampler functionality is under ParentBased logic #6205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug where:
ShouldSample
logic for every span, but for child spans, they should always respect the parent span sampling decision in XRay Sampler (as is already done in OTel Java and OTel .NET)The changes introduced in this PR are as follows:
remote_sampler
ofNewRemoteSampler
under a single ParentBased SamplerExisting Issue(s):
Related
Testing: