Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XRay Sampler] Fix - Ensure all XRay Sampler functionality is under ParentBased logic #80

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

jj22ee
Copy link
Contributor

@jj22ee jj22ee commented Oct 1, 2024

Issue #, if available:

This PR fixes #79
This fixes the bug where:

  • While the subcomponents of XRay Sampler uses ParentBased logic to short-circuit the Parent's Sampling Decision, the XRay Sampling Statistics recording logic is not skipped when a Parent's Sampling Decision is found. This causes XRay Sampler to produce Sampling Statistics based on number of Spans (regardless of Parent's Sampling Decision), while XRay Sampler should produce Sampling Statistics based on number of Traces (aka the number of root Spans that makes the Sampling Decision)

Description of changes:

  1. Wrap entire XRay Sampler Internal Logic under a single ParentBased Sampler
  2. Remove use of redundant ParentBased Sampler logic for internal subcomponents for XRay Sampler.

Testing:

  1. Added unit tests to verify ParentBased sampling decisions
  2. Original Sampler functionality tested locally using Sampler Test Bed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jj22ee jj22ee requested a review from a team as a code owner October 1, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants