Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all XRay Sampler functionality is under ParentBased logic #1488

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

jj22ee
Copy link
Contributor

@jj22ee jj22ee commented Oct 4, 2024

Description:

This fixes the bug where:

  • While the subcomponents of XRay Sampler uses ParentBased logic to short-circuit the Parent's Sampling Decision, the XRay Sampling Statistics recording logic is not skipped when a Parent's Sampling Decision is found. This causes XRay Sampler to produce Sampling Statistics based on number of Spans (regardless of Parent's Sampling Decision), while XRay Sampler should produce Sampling Statistics based on number of Traces (aka the number of root Spans that makes the Sampling Decision)

The changes introduced in this PR are as follows:

  • Wrap entire internal XrayRulesSampler of AwsXrayRemoteSampler under a single ParentBased Sampler
  • Remove use of redundant ParentBased Sampler logic for internal subcomponents for XRay Sampler.

Existing Issue(s):
Related

Testing:

Documentation:

Outstanding items:

@jj22ee jj22ee requested a review from a team as a code owner October 4, 2024 19:41
@github-actions github-actions bot requested review from srprash and wangzlei October 4, 2024 19:41
@jj22ee jj22ee force-pushed the xray-parent-based-sampler branch from 6ce6142 to fb1cd6e Compare October 4, 2024 20:07
@trask trask merged commit 7bb0a73 into open-telemetry:main Oct 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants