-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[proposal] Refactor aggregation and add exemplars support #4220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:SDK
Related to an SDK package
area:metrics
Part of OpenTelemetry Metrics
proposal
labels
Jun 14, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4220 +/- ##
=======================================
- Coverage 83.3% 82.7% -0.6%
=======================================
Files 181 192 +11
Lines 13986 14714 +728
=======================================
+ Hits 11657 12179 +522
- Misses 2102 2301 +199
- Partials 227 234 +7
|
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Jul 19, 2023
Part of open-telemetry#4220 Instead of using an aggregator to filter measured attributes, directly filter the attributes in the constructed Measure function the Builder creates. Include unit and integration testing of new filtering.
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Jul 19, 2023
Part of open-telemetry#4220 Instead of using an aggregator to filter measured attributes, directly filter the attributes in the constructed Measure function the Builder creates. Include unit and integration testing of new filtering.
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Jul 19, 2023
Part of open-telemetry#4220 Instead of using an aggregator to filter measured attributes, directly filter the attributes in the constructed Measure function the Builder creates. Include unit and integration testing of new filtering.
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Jul 19, 2023
Part of open-telemetry#4220 Instead of using an aggregator to filter measured attributes, directly filter the attributes in the constructed Measure function the Builder creates. Include unit and integration testing of new filtering.
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Jul 19, 2023
Part of open-telemetry#4220 Instead of using an aggregator to filter measured attributes, directly filter the attributes in the constructed Measure function the Builder creates. Include unit and integration testing of new filtering.
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Jul 19, 2023
Part of open-telemetry#4220 Instead of using an aggregator to filter measured attributes, directly filter the attributes in the constructed Measure function the Builder creates. Include unit and integration testing of new filtering.
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Jul 19, 2023
Part of open-telemetry#4220 Instead of using an aggregator to filter measured attributes, directly filter the attributes in the constructed Measure function the Builder creates. Include unit and integration testing of new filtering.
MrAlias
added a commit
that referenced
this pull request
Jul 20, 2023
* Replace filter aggregator with direct filter on measure Part of #4220 Instead of using an aggregator to filter measured attributes, directly filter the attributes in the constructed Measure function the Builder creates. Include unit and integration testing of new filtering. * Update sdk/metric/internal/aggregate/aggregate.go Co-authored-by: David Ashpole <dashpole@google.com> --------- Co-authored-by: David Ashpole <dashpole@google.com>
This was referenced Jul 24, 2023
Replace with #4455 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aggregate
Aggregator
interface into anInput
andOutput
function (this is how it is used in the SDK anyways)internal/exemplar
package (part of Add support for exemplars #559).