Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint to check for known cross-module internal packages #4426

Merged
merged 7 commits into from
Aug 11, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 8, 2023

Part of #3846

Help prevent a revert of all the changes made to remove cross module internal package dependencies.

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 8, 2023
@MrAlias MrAlias marked this pull request as ready for review August 8, 2023 20:20
@MrAlias MrAlias added this to the v1.17.0/v0.40.0 milestone Aug 9, 2023
.golangci.yml Outdated Show resolved Hide resolved
@pellared
Copy link
Member

I want to say that I like this 👍

It will help also double-check that #3846 is implemented correctly.

.golangci.yml Outdated Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #4426 (0053058) into main (e9014a2) will decrease coverage by 0.1%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4426     +/-   ##
=======================================
- Coverage   78.8%   78.8%   -0.1%     
=======================================
  Files        253     253             
  Lines      20644   20644             
=======================================
- Hits       16283   16281      -2     
- Misses      4012    4014      +2     
  Partials     349     349             

see 1 file with indirect coverage changes

@MrAlias MrAlias merged commit 7b9fb7a into open-telemetry:main Aug 11, 2023
22 checks passed
@MrAlias MrAlias deleted the depguard-internal branch August 11, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants