Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templatize internal/matchers for all internaltest packages #4430

Merged
merged 5 commits into from
Aug 10, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 9, 2023

Part of #3846

Follow up to #4424

The internaltest packages all import the otel/internal/matchers package. Use gotmpl to templatize this package and import a local copy for all internaltest copies.

Validated using the .golangci.yml file from #4426. It successfully runs with this change.

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #4430 (cecfb49) into main (319cb3a) will decrease coverage by 2.4%.
The diff coverage is 4.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4430     +/-   ##
=======================================
- Coverage   81.2%   78.8%   -2.4%     
=======================================
  Files        247     253      +6     
  Lines      20006   20645    +639     
=======================================
+ Hits       16258   16282     +24     
- Misses      3405    4014    +609     
- Partials     343     349      +6     
Files Changed Coverage Δ
exporters/jaeger/internal/internaltest/harness.go 0.0% <ø> (ø)
exporters/jaeger/internal/matchers/expectation.go 0.0% <0.0%> (ø)
exporters/jaeger/internal/matchers/expecter.go 0.0% <0.0%> (ø)
exporters/zipkin/internal/internaltest/harness.go 0.0% <ø> (ø)
exporters/zipkin/internal/matchers/expectation.go 0.0% <0.0%> (ø)
exporters/zipkin/internal/matchers/expecter.go 0.0% <0.0%> (ø)
internal/matchers/expectation.go 0.0% <ø> (ø)
internal/matchers/expecter.go 0.0% <ø> (ø)
sdk/internal/internaltest/harness.go 100.0% <ø> (ø)
sdk/internal/matchers/expectation.go 8.3% <8.3%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

@MrAlias MrAlias merged commit c513972 into open-telemetry:main Aug 10, 2023
20 of 22 checks passed
@MrAlias MrAlias deleted the gotmpl-internal-matchers branch August 10, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants