Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete temporary directory in tomcat servlet3 tests #12455

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Delete temporary directory in tomcat servlet3 tests #12455

merged 3 commits into from
Oct 17, 2024

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Oct 17, 2024 •
edited
Loading

deleteOnExit can only delete empty directories, it is easier to let junit manage the temp directory.

@laurit laurit requested a review from a team as a code owner October 17, 2024 12:28
@laurit laurit mentioned this pull request Oct 17, 2024
Merged
@trask trask merged commit aa12231 into open-telemetry:main Oct 17, 2024
56 checks passed
@laurit laurit deleted the tomcat-tmp-dir branch October 18, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurit @trask