Stabilize instrumentation-api and introduce jApiCmp checks #6566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Sep 9, 2022
...ion-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/SpanSuppressors.java
Show resolved
Hide resolved
oh yes, let's do it 🎉 |
trask
reviewed
Sep 9, 2022
| @@ -62,6 +62,18 @@ jobs: | |||
| exit 1 | |||
| fi | |||
|
|
|||
| - name: Check for jApiCmp diffs | |||
There was a problem hiding this comment.
we only run assemble above (not check or build), maybe add assemble jApiCmp above, or run jApiCmp on assemble (or even compileJava?) instead of on check
trask
approved these changes
Sep 9, 2022
Merged
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 23, 2022
…metry#6566) * Stabilize instrumentation-api and introduce jApiCmp checks * Update Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
…metry#6566) * Stabilize instrumentation-api and introduce jApiCmp checks * Update Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
…metry#6566) * Stabilize instrumentation-api and introduce jApiCmp checks * Update Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4467
Resolves #2892 (well, except actual semantic conventions, but I suppose we could have another issue for tracking these)
@trask should we merge this before 1.18?