Adds dedicated tests for OC shim #7488
Conversation
...shim/testing/src/test/java/io/opentelemetry/opencensusshim/JavaagentInstrumentationTest.java
Outdated
Show resolved
Hide resolved
...shim/testing/src/test/java/io/opentelemetry/opencensusshim/JavaagentInstrumentationTest.java
Outdated
Show resolved
Hide resolved
dmarkwat
force-pushed
the
oc-shim-dedicated-tests
branch
from
5b632dc
to
697f22e
Compare
|
The tests won't pass until open-telemetry/opentelemetry-java#4900 is merged, but the cases should largely be covered. |
...pencensus-shim/testing/src/test/java/io/opentelemetry/opencensusshim/SpanConverterProxy.java
Outdated
Show resolved
Hide resolved
...shim/testing/src/test/java/io/opentelemetry/opencensusshim/JavaagentInstrumentationTest.java
Outdated
Show resolved
Hide resolved
dmarkwat
force-pushed
the
oc-shim-dedicated-tests
branch
2 times, most recently
from
4c3c412
to
c278c14
Compare
...ng-common/src/main/java/io/opentelemetry/instrumentation/testing/util/TelemetryDataUtil.java
Outdated
Show resolved
Hide resolved
|
Rebased on main and built against the recently-released opentelemetry-java |
dmarkwat
force-pushed
the
oc-shim-dedicated-tests
branch
2 times, most recently
from
869bd34
to
d7f185d
Compare
|
Rebased on main for version 1.24.0 of otel-java and looking good, apart from the one outlying comment wrt the opencensus-shim-generated instrumentation name, mentioned here. |
...shim/testing/src/test/java/io/opentelemetry/opencensusshim/JavaagentInstrumentationTest.java
Outdated
Show resolved
Hide resolved
|
Should this have been closed? Or was it github automation? I still think this is required to adequately test the OC shim running under the javaagent. cc @jack-berg |
|
@dmarkwat github automatically closes issues and pull requests when a pull request that says something like |
dmarkwat
force-pushed
the
oc-shim-dedicated-tests
branch
from
00bcb39
to
3e570ec
Compare
dmarkwat
force-pushed
the
oc-shim-dedicated-tests
branch
from
3e570ec
to
e0adcda
Compare
|
Rebased and should be good to go 👍 |
|
thx @dmarkwat for your efforts and patience! |
|
Cheers, i was happy to do it. And thanks for your patience and guidance as well. I hope to have more contributions for this awesome project soon! |
Per suggestion: open-telemetry/opentelemetry-java#4900 (review)
Note: these tests won't succeed until a new version of upstream is published with the requisite changes to make the opencensus shim work under the otel javaagent.
Happy to add more tests to this. However, until upstream is released, that's mostly eyeballing everything, so will wait for a sign that the current state of upstream is sufficient to move forward before spending the time.