Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds version to otel tracer instrumentation scope #5336

Merged
merged 6 commits into from
Apr 4, 2023

Conversation

dmarkwat
Copy link
Contributor

@dmarkwat
Copy link
Contributor Author

dmarkwat commented Mar 30, 2023

While I'm here I also added same for opentracing, should that ever get the same javaagent testing treatment as opencensus. OT unfortunately lacks the same metadata class that OC has (OpenCensusLibraryInformation) afaict, though, so the version value is hard coded. Given the project is effectively inactive, I figured this should be "OK" under the circumstances. However, just say the word and I'll change it or drop it since nothing is affected at this time.

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.01 ⚠️

Comparison is base (25d767f) 91.07% compared to head (53be282) 91.06%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5336      +/-   ##
============================================
- Coverage     91.07%   91.06%   -0.01%     
- Complexity     4863     4865       +2     
============================================
  Files           546      546              
  Lines         14371    14389      +18     
  Branches       1354     1354              
============================================
+ Hits          13089    13104      +15     
- Misses          892      895       +3     
  Partials        390      390              
Impacted Files Coverage Δ
...y/opencensusshim/OpenTelemetrySpanBuilderImpl.java 86.20% <80.00%> (-0.98%) ⬇️
...a/io/opentelemetry/opentracingshim/TracerShim.java 70.49% <80.00%> (+1.26%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@jack-berg jack-berg merged commit 9bd1a51 into open-telemetry:main Apr 4, 2023
@dmarkwat dmarkwat deleted the add-oc-shim-version branch April 4, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants