-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop publishing opentelemetry-exporter-jaeger-proto artifact #4724
Stop publishing opentelemetry-exporter-jaeger-proto artifact #4724
Conversation
Codecov ReportBase: 90.63% // Head: 90.60% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4724 +/- ##
============================================
- Coverage 90.63% 90.60% -0.03%
+ Complexity 4907 4906 -1
============================================
Files 570 567 -3
Lines 14751 14728 -23
Branches 1413 1414 +1
============================================
- Hits 13370 13345 -25
- Misses 954 959 +5
+ Partials 427 424 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
f3477a5
to
417821b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice gradle work 👍
Related to #4661 and #4701.
Adds tooling to the BOM conventions that allows artifacts to be included in the BOM which are no longer published. The first artifact to be referenced like this is
:expoters:jaeger-proto
(opentelemetry-exporter-jaeger-proto
). I've added a test to to:all
that confirms that the public classes ofopentelemetry-exporter-jaeger-proto
are still accessible when using the BOM.Here's what the BOM looks like when I run
./gradlew publishToMavenLocal
:Notice the version for
opentelemetry-exporter-jaeger-proto
is different than the others.