-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add base2ExponentialHistogram to Aggregation #5143
Add base2ExponentialHistogram to Aggregation #5143
Conversation
f8ac7a1
to
8418adb
Compare
* Aggregates measurements into a base-2 {@link MetricDataType#EXPONENTIAL_HISTOGRAM} using the | ||
* default {@code maxBuckets} and {@code maxScale}. | ||
*/ | ||
static Aggregation base2ExponentialBucketHistogram() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name was switched to "base2 exponential bucket histogram" to avoid confusing folks that may expect "exponential" to refer to base 10. Convo available here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, and I'm planning on adding Base2
prefix to the internal ExponentialHistogram*
classes in a followup.
Codecov ReportBase: 91.07% // Head: 91.08% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5143 +/- ##
============================================
+ Coverage 91.07% 91.08% +0.01%
- Complexity 4865 4869 +4
============================================
Files 548 548
Lines 14368 14373 +5
Branches 1377 1378 +1
============================================
+ Hits 13085 13092 +7
+ Misses 891 890 -1
+ Partials 392 391 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…y-java into stablize-exponential-histogram-1
No description provided.