Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base2ExponentialHistogram to Aggregation #5143

Merged

Conversation

jack-berg
Copy link
Member

No description provided.

@jack-berg jack-berg requested a review from a team January 21, 2023 14:53
@jack-berg jack-berg force-pushed the stablize-exponential-histogram-1 branch from f8ac7a1 to 8418adb Compare January 21, 2023 15:05
* Aggregates measurements into a base-2 {@link MetricDataType#EXPONENTIAL_HISTOGRAM} using the
* default {@code maxBuckets} and {@code maxScale}.
*/
static Aggregation base2ExponentialBucketHistogram() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name was switched to "base2 exponential bucket histogram" to avoid confusing folks that may expect "exponential" to refer to base 10. Convo available here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and I'm planning on adding Base2 prefix to the internal ExponentialHistogram* classes in a followup.

@codecov
Copy link

codecov bot commented Jan 21, 2023

Codecov Report

Base: 91.07% // Head: 91.08% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (7913fb3) compared to base (33e6bf3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5143      +/-   ##
============================================
+ Coverage     91.07%   91.08%   +0.01%     
- Complexity     4865     4869       +4     
============================================
  Files           548      548              
  Lines         14368    14373       +5     
  Branches       1377     1378       +1     
============================================
+ Hits          13085    13092       +7     
+ Misses          891      890       -1     
+ Partials        392      391       -1     
Impacted Files Coverage Δ
...lemetry/exporter/internal/otlp/OtlpConfigUtil.java 89.92% <100.00%> (+0.23%) ⬆️
...java/io/opentelemetry/sdk/metrics/Aggregation.java 100.00% <100.00%> (ø)
...k/metrics/internal/aggregator/AggregationUtil.java 100.00% <100.00%> (ø)
...rnal/aggregator/AdaptingCircularBufferCounter.java 90.56% <0.00%> (+3.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants