Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Base2 prefix to internal exponential histogram classes #5179

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

jack-berg
Copy link
Member

Followup to #5143.

@jack-berg jack-berg requested a review from a team February 5, 2023 19:33
@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Base: 91.05% // Head: 91.05% // No change to project coverage 👍

Coverage data is based on head (ca903f3) compared to base (92403b0).
Patch coverage: 95.23% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5179   +/-   ##
=========================================
  Coverage     91.05%   91.05%           
  Complexity     4869     4869           
=========================================
  Files           548      548           
  Lines         14373    14373           
  Branches       1378     1378           
=========================================
  Hits          13087    13087           
  Misses          893      893           
  Partials        393      393           
Impacted Files Coverage Δ
...egator/DoubleBase2ExponentialHistogramBuckets.java 69.44% <90.00%> (ø)
...java/io/opentelemetry/sdk/metrics/Aggregation.java 100.00% <100.00%> (ø)
...l/aggregator/Base2ExponentialHistogramIndexer.java 100.00% <100.00%> (ø)
...tor/DoubleBase2ExponentialHistogramAggregator.java 94.66% <100.00%> (ø)
...nal/view/Base2ExponentialHistogramAggregation.java 100.00% <100.00%> (ø)
...ava/io/opentelemetry/sdk/internal/RateLimiter.java 94.11% <0.00%> (-5.89%) ⬇️
...nternal/state/DefaultSynchronousMetricStorage.java 93.10% <0.00%> (+1.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg merged commit feb0297 into open-telemetry:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants